[bitnami/thanos] feat!: ♻️ 🔒 Refactor and enable NetworkPolicy by default #22687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ault Signed-off-by: Javier Salmeron Garcia <jsalmeron@vmware.com>
Signed-off-by: Javier Salmeron Garcia <jsalmeron@vmware.com>
Signed-off-by: Javier J. Salmerón-García <jsalmeron@vmware.com>
Signed-off-by: Javier Salmeron Garcia <jsalmeron@vmware.com>
Signed-off-by: Javier J. Salmerón-García <jsalmeron@vmware.com>
Signed-off-by: Javier Salmeron Garcia <jsalmeron@vmware.com>
Signed-off-by: Javier J. Salmerón-García <jsalmeron@vmware.com>
Signed-off-by: Javier J. Salmerón-García <jsalmeron@vmware.com>
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
dgomezleon
previously approved these changes
Feb 13, 2024
Signed-off-by: Javier Salmeron Garcia <jsalmeron@vmware.com>
antonblr
pushed a commit
to antonblr/charts
that referenced
this pull request
Feb 15, 2024
…ault (bitnami#22687) * [bitnami/thanos] feat!: ♻️ 🔒 Refactor and enable NetworkPolicy by default Signed-off-by: Javier Salmeron Garcia <jsalmeron@vmware.com> * fix: 🐛 Allow ingress for members of the chart Signed-off-by: Javier Salmeron Garcia <jsalmeron@vmware.com> * fix: 🐛 Add allowExternalEgress Signed-off-by: Javier Salmeron Garcia <jsalmeron@vmware.com> * test: 🔧 Update cypress endpoint Signed-off-by: Javier Salmeron Garcia <jsalmeron@vmware.com> * Update values.yaml Signed-off-by: Javier J. Salmerón-García <jsalmeron@vmware.com> * Update README.md with readme-generator-for-helm Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com> * chore: ♻️ Unify queryfrontend and query-frontend Signed-off-by: Javier Salmeron Garcia <jsalmeron@vmware.com> --------- Signed-off-by: Javier Salmeron Garcia <jsalmeron@vmware.com> Signed-off-by: Javier J. Salmerón-García <jsalmeron@vmware.com> Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com> Co-authored-by: Bitnami Containers <bitnami-bot@vmware.com>
joancafom
pushed a commit
to dalbani/charts
that referenced
this pull request
Feb 22, 2024
…ault (bitnami#22687) * [bitnami/thanos] feat!: ♻️ 🔒 Refactor and enable NetworkPolicy by default Signed-off-by: Javier Salmeron Garcia <jsalmeron@vmware.com> * fix: 🐛 Allow ingress for members of the chart Signed-off-by: Javier Salmeron Garcia <jsalmeron@vmware.com> * fix: 🐛 Add allowExternalEgress Signed-off-by: Javier Salmeron Garcia <jsalmeron@vmware.com> * test: 🔧 Update cypress endpoint Signed-off-by: Javier Salmeron Garcia <jsalmeron@vmware.com> * Update values.yaml Signed-off-by: Javier J. Salmerón-García <jsalmeron@vmware.com> * Update README.md with readme-generator-for-helm Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com> * chore: ♻️ Unify queryfrontend and query-frontend Signed-off-by: Javier Salmeron Garcia <jsalmeron@vmware.com> --------- Signed-off-by: Javier Salmeron Garcia <jsalmeron@vmware.com> Signed-off-by: Javier J. Salmerón-García <jsalmeron@vmware.com> Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com> Co-authored-by: Bitnami Containers <bitnami-bot@vmware.com> Signed-off-by: Jose Antonio Carmona <jcarmona@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Javier Salmeron Garcia jsalmeron@vmware.com
BREAKING CHANGES
Description of the change
This major version changes the NetworkPolicy objects and creates one per Thanos component. The
networkPolicycommon value was removed in favor ofCOMPONENT.networkPolicy. Also, NetworkPolicy objects are deployed by default. This can be changed by settingCOMPONENT.networkPolicy.enabled=falsebeingCOMPONENTone of the Thanos components.This version also removes deprecated service port values like
receive.service.http.portin favor ofrecieve.service.ports.http, as well asexistingServiceAccount.Benefits
Improved security of the chart
Possible drawbacks
Applicable issues
Additional information
Checklist
Chart.yamlaccording to semver. This is not necessary when the changes only affect README.md files.README.mdusing readme-generator-for-helm